Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ShellCheck on CI. #421

Merged
merged 2 commits into from
May 10, 2020
Merged

Run ShellCheck on CI. #421

merged 2 commits into from
May 10, 2020

Conversation

reitermarkus
Copy link
Member

No description provided.

@reitermarkus reitermarkus requested review from Dylan-DPC-zz and a team as code owners May 3, 2020 13:19
@reitermarkus reitermarkus force-pushed the shellcheck branch 28 times, most recently from 8a02898 to d59bc06 Compare May 3, 2020 14:59
@reitermarkus reitermarkus force-pushed the shellcheck branch 5 times, most recently from 6d200a9 to 5718359 Compare May 4, 2020 08:15
@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 8, 2020
@bors
Try #421:
21a7160
@bors
Copy link
Contributor

bors bot commented May 8, 2020

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 9, 2020
@bors
Try #421:
ecd5da1
@bors
Copy link
Contributor

bors bot commented May 9, 2020

try

Build succeeded:

adamgreig
adamgreig approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we should probably do this in other WG repos too.

bors merge

bors bot added a commit that referenced this pull request May 9, 2020
@bors @reitermarkus
Merge #421
cfefd21 
421: Run ShellCheck on CI. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented May 9, 2020

Build failed:

  • rust-embedded.cross

@adamgreig
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request May 9, 2020
@bors @reitermarkus
Merge #421
7f49210 
421: Run ShellCheck on CI. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented May 9, 2020

Build failed:

  • rust-embedded.cross

@adamgreig
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request May 10, 2020
@bors @reitermarkus
Merge #421
73e0a90 
421: Run ShellCheck on CI. r=adamgreig a=reitermarkus



Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented May 10, 2020

Build failed:

  • rust-embedded.cross

@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented May 10, 2020

Build succeeded:

@bors bors bot merged commit 8a2f734 into master May 10, 2020
@bors bors bot deleted the shellcheck branch May 10, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

@burrbull burrbull Awaiting requested review from burrbull

@therealprof therealprof Awaiting requested review from therealprof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reitermarkus @adamgreig